-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Reproducible Builds #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
changed the title
Standardize Reproducible Builds to x86
Revamp Reproducible Builds
Jul 25, 2024
Co-authored-by: Joshua Colvin <[email protected]>
…into docker-checks
joshuacolvin0
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Joshua Colvin <[email protected]>
Co-authored-by: Joshua Colvin <[email protected]>
joshuacolvin0
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rory-ocl
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains major changes to reproducible deployments and verification of Stylus contracts. To read the motivation, and understand exactly how it works, see Contract Verification For Stylus Programs.
Changelog
--rust-stable
flag as it instead relies on the Stylus program'srust-toolchain.toml
file to specify a versionreproducible
subcommand of Cargo stylus, as insteaddeploy
,check
, andverify
are made reproducible by default by running in a Docker environmentrust-toolchain.toml
files that do not contain a specific release channel, for instance,stable
,nightly
,beta
are not enough. A user must declare a specific nightly version of amajor.minor.patch
versionrust:1.79
image. This is simply used for installing cargo, but the user will specify the exact toolchain they plan to use for building and deploying their actual project--no-verify
flag